-
Notifications
You must be signed in to change notification settings - Fork 3.3k
fix: add autocompleteOptions in the .yaml config #6895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add autocompleteOptions in the .yaml config #6895
Conversation
Hey @Patrick-Erichsen, here's the PR as discussed! |
90c14c1
to
da3c07f
Compare
729263e
to
a9cdab9
Compare
The CI errors are here likely related to some recent changes on |
Haha Thank you! @Patrick-Erichsen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@panyamkeerthana there is already an autocompleteOptions
property on the model config. It appears to be undocumented. Were you aware of this, or is it missing specific properties?
@RomneyDa Yes, I was aware of this and you're right! It was missing the context restriction properties but so was I guess, my understanding of it was that context behavior is a user preference that should apply across all models through a single config point. However, I'm open to moving this to a model-level config if you feel that will provide a more modular config design! 😊 |
4b933b1
to
b4e389c
Compare
Got it! A nice thing about YAML is that you can use YAML templating to easily add the same configuration to all models, in an assistant, which isn't fully the single-point effect but pretty close. You were probably already aware of that as well, I think we would prefer the more modular approach |
Really good point about YAML templating, appreciate the perspective.😁 I’ll get the changes pushed soon! |
added schema properties and tabAutocompleteOptions schema to to support in YAML config file, allowing proper override of default values from parameters.ts. added .optional() tags to tabAutocompleteOptions properties to enable partial override from the config.yaml file.
importing from the built config-types package instead of its src/
b4e389c
to
d25c0a8
Compare
d25c0a8
to
d7a6b82
Compare
@panyamkeerthana could you revert extraneous package lock and completion provider changes? |
@panyamkeerthana also add docs for the the non-experimental options? |
d7a6b82
to
9c5b9d6
Compare
55c91be
to
d57990b
Compare
@RomneyDa I've added to documentation. Thanks for pointing me to @ferenci84’s implementation, really helpful! 🙌 😊 |
- added context restriction properties to model autocompleteOptions schema - discarded changes to add global tabAutocompleteOptions to config schema - added experimental parameters to both config-types. - added YAML alternative note to json reference. - updated YAML configuration example with per-model options. - added reference documentation with parameters for autocomplete options.
a12944f
to
8fe5077
Compare
Description
-This re-enables the deprecated tabAutocompleteOptions support to the YAML configuration schema on the global level and adds experimental parameters to tabAutocompleteOptions schema to enable overriding default values from
parameters.ts
via config.yaml files. Did this to keep the context limited to the current opened file.tabAutocompleteOptions
into the global YAML config schema..optional()
tags to schema properties to allow partial overrides.continueConfig
.tabAutocompleteOptions
during config unroll.To restrict tab autocomplete context to just the currently opened file, add this configuration to config.yaml:
Example
config.yaml
This PR is supposed to resolve #6767