Skip to content

fix: mcp ssl verification #6884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

paulnegz
Copy link

@paulnegz paulnegz commented Jul 30, 2025

Description

fix issue 6215

Checklist

  • [] I've read the contributing guide
  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screen recording or screenshot

[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]

Tests

[ What tests were added or updated to ensure the changes work as expected? ]


Summary by cubic

Fixed SSL verification handling in MCP transports.

  • Bug Fixes
    • Passes verifySsl option to SSE and streamable-http transports, allowing SSL verification to be disabled if needed.
    • Transforms api_key to apiKey in config parsing, preventing authentication issues with providers that use api_key.

@paulnegz paulnegz requested a review from a team as a code owner July 30, 2025 05:02
@paulnegz paulnegz requested review from RomneyDa and removed request for a team July 30, 2025 05:02
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jul 30, 2025
@paulnegz paulnegz force-pushed the 6215-mcp-ssl-verification-fix branch 3 times, most recently from a4ed0dc to 46e4bab Compare July 30, 2025 05:09
@paulnegz paulnegz changed the title mcp ssl verification fix fix: mcp ssl verification Jul 30, 2025
@paulnegz paulnegz force-pushed the 6215-mcp-ssl-verification-fix branch from 46e4bab to 83259db Compare July 30, 2025 05:12
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Jul 30, 2025
@paulnegz paulnegz force-pushed the 6215-mcp-ssl-verification-fix branch 2 times, most recently from f426ac4 to d2e32ac Compare July 30, 2025 05:15
@Patrick-Erichsen
Copy link
Collaborator

The CI errors are here likely related to some recent changes on main looking into it now 👍

@paulnegz
Copy link
Author

The CI errors are here likely related to some recent changes on main looking into it now 👍

thanks! saw it on 2 separate MRs so I suspected it wasn't introduced by my change but great to be certain

@paulnegz paulnegz force-pushed the 6215-mcp-ssl-verification-fix branch from e687195 to a5ddf24 Compare July 30, 2025 20:49
….yaml parsing to support both apiKey and api_key fields.
@paulnegz paulnegz force-pushed the 6215-mcp-ssl-verification-fix branch from a5ddf24 to 053e540 Compare July 30, 2025 20:52
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jul 30, 2025
@RomneyDa
Copy link
Collaborator

@paulnegz appears to still be failing quite a few tests

@paulnegz
Copy link
Author

@paulnegz appears to still be failing quite a few tests

looking into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

Unable to disable SSL verification for sse or streamable-http MCP service
3 participants