Fetch 14: Read node extra ca certs, better NO_PROXY logic #6164
+716
−355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for continuedev failed. Why did it fail? →
|
dosubot
bot
added
the
size:XL
![recurseml[bot]](https://avatars.githubusercontent.com/in/1054195?s=60&v=4){kind=small}
|
😱 Found 2 issues. Time to roll up your sleeves! 😱 |
Closed
…dev/continue into dallin/node-extra-ca-certs
dosubot
bot
added
size:XXL
RomneyDa
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reads certs from NODE_EXTRA_CA_CERTS for custom fetch.
It appears that whenever agent
cais manually set, NODE_EXTRA_CA_CERTS is not read, even though the node docs seem to imply that NODE_EXTRA_CA_CERTS are added to tls on initialization. It seems node-fetch injects these under the hood.Adds a simple certs cache that caches
This fixes missing NODE_EXTRA_CA_CERTS and speeds up fetch.
Also adds port and case sensitivity issue fixes for NO_PROXY (taken from #6115)