Skip to content

fix: enable parsing of OpenAI-compatible agent mode messages #6108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

shssoichiro
Copy link

Description

This implements proper parsing of agent mode messages for qwen3 and other OpenAI-compatible models which support tool use. This means that agent mode for Open-AI compatible models will now work properly, with the exception of messages which include multiple tool calls in a single message. Existing code does not support this, and this requires further changes of unknown scope.

Fixes #5419.

Checklist

  • I've read the contributing guide
  • The relevant docs, if any, have been updated or created
  • The relevant tests, if any, have been updated or created

Screenshots

See issue #5419 for Before screenshots.

image

Tests

Added a new test suite for the sessionSlice reducer's streamUpdate function, including all cases related to this functionality.

@shssoichiro shssoichiro requested a review from a team as a code owner June 13, 2025 03:03
@shssoichiro shssoichiro requested review from Patrick-Erichsen and removed request for a team June 13, 2025 03:03
Copy link

cubic-dev-ai bot commented Jun 13, 2025

Your cubic subscription is currently inactive. Please reactivate your subscription to receive AI reviews and use cubic.

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jun 13, 2025
Copy link

netlify bot commented Jun 13, 2025

Deploy Preview for continuedev ready!

Name Link
🔨 Latest commit aad99fc
🔍 Latest deploy log https://app.netlify.com/projects/continuedev/deploys/684b94fd7fd76b0008618444
😎 Deploy Preview https://deploy-preview-6108--continuedev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

github-actions bot commented Jun 13, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@shssoichiro
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

Copy link

recurseml bot commented Jun 13, 2025

😱 Found 1 issue. Time to roll up your sleeves! 😱

@DotDawson
Copy link

Are the PR test failures just flake? Reading through the logs, it looks like many of these tests don't even reach the point where extest run-tests is called. They seem to fail with 5xx errors during vscode extension installations. I don't see any reason this change would cause those failures.

The tests ran on June 12 @ 8:07 PM PST, which was not at the same time as the big google outage on June 12 between 1PM PST and 4PM PST.

I think the tests should be re-run.

@shssoichiro
Copy link
Author

That was my thinking as well. I don't have permission to re-run the tests, so someone associated with the project will need to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

Agent mode not work when using Qwen3 model
2 participants