Skip to content

feat: add proxy support for ripgrep download #6106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dipfocus
Copy link

Description

  • Added support for using a proxy (https_proxy/HTTPS_PROXY) when downloading ripgrep.
  • The download process will automatically use the proxy if one is configured, and will work as usual if no proxy is set.

Checklist

  • I've read the contributing guide
  • The relevant docs, if any, have been updated or created
  • The relevant tests, if any, have been updated or created

Screenshots

N/A

Tests

  • Manually tested ripgrep download with and without a proxy environment. Both scenarios work as expected.

@dipfocus dipfocus requested a review from a team as a code owner June 13, 2025 01:33
@dipfocus dipfocus requested review from Patrick-Erichsen and removed request for a team June 13, 2025 01:33
Copy link

cubic-dev-ai bot commented Jun 13, 2025

Your cubic subscription is currently inactive. Please reactivate your subscription to receive AI reviews and use cubic.

Copy link

netlify bot commented Jun 13, 2025

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit 1188688
🔍 Latest deploy log https://app.netlify.com/projects/continuedev/deploys/68520e2592fd630008a486ee

Copy link

github-actions bot commented Jun 13, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 13, 2025
Copy link

recurseml bot commented Jun 13, 2025

✨ No issues found! Your code is sparkling clean! ✨

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Jun 17, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 17, 2025
@Patrick-Erichsen
Copy link
Collaborator

Patrick-Erichsen commented Jun 17, 2025

Thanks for the contribution here @dipfocus ! Once you sign the CLA we can get this merged 👍

Also appears to be a prettier issue: https://github.com/continuedev/continue/actions/runs/15624381783/job/44015762325?pr=6106#step:5:6

@dipfocus
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants