Include local blocks for hub assistants #6074
Open
+198
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your cubic subscription is currently inactive. Please reactivate your subscription to receive AI reviews and use cubic. |
✅ Deploy Preview for continuedev canceled.
|
dosubot
bot
added
the
size:L
![recurseml[bot]](https://avatars.githubusercontent.com/in/1054195?s=60&v=4){kind=small}
| } | ||
| const rootPath = | ||
| packageIdentifier.uriType === "file" | ||
| ? dirname(getCleanUriPath(packageIdentifier.filePath)) |
There was a problem hiding this comment.
Unsafe URI path handling: The code assumes packageIdentifier.filePath exists but doesn't check if it's undefined. If filePath is undefined, this will cause a runtime error. Should add a null check before using filePath.
React with 👍 to tell me that this comment was useful, or 👎 if not (and I'll stop posting more comments like this in the future)
|
😱 Found 1 issue. Time to roll up your sleeves! 😱 |
|
I think the test failures here are legit @RomneyDa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for local blocks to hub assistants
Achieves this by creating a simple "dud" assistant to unroll, made up of any local blocks
Moves some utils around, including retrieval of local block files and creation of a registry. This is mostly so that adding this support for JSON is simple in the future.
This should be followed by a PR to add support for JSON