Handle null-values of XML attributes #112
Open
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Wouldn’t it be better to fallback to the |
Member
|
Having some attributes without a namespace is actually valid, but deprecated, see https://www.w3.org/TR/REC-rdf-syntax/#eventterm-attribute-URI so we should properly support that. |
ausi
reviewed
Nov 6, 2025
Comment on lines
+187
to
+189
| if ($attr->namespaceURI && $attr->localName) { | ||
| $metadata[] = $this->parseValue($attr->namespaceURI, $attr->localName, $attr->value); | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| if ($attr->namespaceURI && $attr->localName) { | |
| $metadata[] = $this->parseValue($attr->namespaceURI, $attr->localName, $attr->value); | |
| } | |
| $metadata[] = $this->parseValue($attr->namespaceURI ?? $desc->namespaceURI, $attr->localName, $attr->value); |
ausi
reviewed
Nov 6, 2025
Comment on lines
-192
to
+196
| $metadata[] = $this->parseValue($node->namespaceURI, $node->localName, $node); | ||
| if ($node->namespaceURI && $node->localName) { | ||
| $metadata[] = $this->parseValue($node->namespaceURI, $node->localName, $node); | ||
| } |
Member
There was a problem hiding this comment.
This should be reverted as nodes without namespaces are not supported.
Member
|
While testing with your image I noticed that a broken XMP metadata results in the image having no metadata at all. We should probably fix that so the valid metadata parts are still shown correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried parsing an image that resulted in an exception message
Contao\Image\Metadata\XmpFormat::parseValue(): Argument #1 ($namespace) must be of type string, null given, because the value for$attr->namespaceURIwas null. Not sure how that can happen, and no idea how to write a test for that, but I think the library should rather ignore these values than throw an exception?