Skip to content

feat: add unique service instance identifiers to router - #409

Draft
piksel wants to merge 1 commit into
mainfrom
feat/service-list
Draft

feat: add unique service instance identifiers to router#409
piksel wants to merge 1 commit into
mainfrom
feat/service-list

Conversation

@piksel

@piksel piksel commented Nov 5, 2023

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecov Bot commented Nov 5, 2023

Copy link
Copy Markdown

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (3428e5e) 79.12% compared to head (7b2ae29) 79.12%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #409   +/-   ##
=======================================
  Coverage   79.12%   79.12%           
=======================================
  Files         102      102           
  Lines        4488     4503   +15     
=======================================
+ Hits         3551     3563   +12     
- Misses        758      760    +2     
- Partials      179      180    +1     
Files Coverage Δ
pkg/router/router.go 67.81% <79.48%> (+1.14%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@favonia

favonia commented Nov 5, 2023

Copy link
Copy Markdown
Contributor

Thank you! In case it helps, it's okay for my application to show duplicate service names. However, I can also see why you want to make them distinct! 😃

@favonia

favonia commented Nov 5, 2023

Copy link
Copy Markdown
Contributor

Alternative approach: maybe in 1.0 API, there could be an API returning the list of services directly, and each service must implement a function showing a name. The ServiceRouter is then closer to a "composite" service that can queue messages and do AsyncSend.

PS: I want to emphasize that I can use the current library as it is just fine, in case you think more discussions could be helpful. 😁 Thank you for your quick response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants