Add krun_set_rootfs_kernel_args API #346
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggoodman
requested review from
jakecorrenti,
MatiasVara,
mtjhrc,
slp and
tylerfanelli
as code owners
ggoodman
force-pushed
the
custom-kernel-cmdline
branch
from
9b5c16e to
3e46947
Compare
|
I haven't done manual testing on this. Not ready for merge. Will circle back. |
|
Thanks for the contribution @ggoodman! If it's not ready for merge, could you make this a Draft PR and mark it as "Ready for Review" when it's done? |
This commit introduces a new API function `krun_set_rootfs_kernel_args` that allows
callers to override kernel arguments related to the root filesystem, replacing the
default "rootfstype=virtiofs rw" parameters in the kernel command line.
New features:
- Added RootfsConfig struct with builder pattern for type-safe configuration
- Supports customizing root device, filesystem type, mount flags, and read-only mode
- Falls back to sensible defaults: /dev/vda1, virtiofs, rw when parameters are NULL
- Integrates with existing kernel command line construction in get_effective_kernel_cmdline()
- Follows established patterns used by other config types like BlockDeviceConfig
API signature:
```c
int32_t krun_set_rootfs_kernel_args(uint32_t ctx_id,
const char *device,
const char *fs_type,
const char *mount_flags,
bool read_only);
```
Signed-off-by: Geoffrey Goodman <[email protected]>
ggoodman
force-pushed
the
custom-kernel-cmdline
branch
from
3e46947 to
d1c5524
Compare
|
@jakecorrenti I'm staring at GitHub and can't find the UI to switch it to draft. |
Looks like I was able to do it for you. It should typically be right under the "Reviewers" section on the right |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new API function
krun_set_rootfs_kernel_argsthat allowscallers to override kernel arguments related to the root filesystem, replacing the
default "rootfstype=virtiofs rw" parameters in the kernel command line.
New features:
API signature:
Fixes #343.