adaptation: support concurrent RPCs via per Pod lock #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jipperinbham
force-pushed
the
feat/nri-pod-lock
branch
from
762da1f to
69b04e9
Compare
For users who do not need to perform cross Pod updates, a new per Pod lock implementation can be selected via WithPodLocking() Option func. Signed-off-by: JP Phillips <[email protected]>
jipperinbham
force-pushed
the
feat/nri-pod-lock
branch
from
69b04e9 to
5a3e611
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For users who do not need to perform cross Pod updates, a new per Pod lock implementation can be selected via
WithPodLocking()Option func. These changes would need to go along with a similar containerd change as containerd/containerd#11671 to both expose the ability to select the per pod locker as well as remove the global lock on each nri RPC invocation in containerd.Addresses #165