Install protoc locally in the source tree

[marquiz]

Install (and use) protoc and plugins under build/tools in the source tree in an attempt to ensure that the correct version of the tooling is always used.

[marquiz]

@klihub

[klihub]

@marquiz I think this would be good, especially if it helps us avoiding to force dockerized protobuilds on ourselves and everybody else in a local development workflow.

One related question though. Since our scripts/install-protobuf is a verbatim copy of the one in the containerd main repo and we (try to semi-regularly) sync it with that, do you think it would be possible to contribute the same changes there, too ?

[marquiz]

One related question though. Since our scripts/install-protobuf is a verbatim copy of the one in the containerd main repo and we (try to semi-regularly) sync it with that, do you think it would be possible to contribute the same changes there, too ?

Yeah, sure, I can try :) As soon as I get this working (i.e. make the ci pass muster).

One gap still remains that we don't check the protoc (or plugins) versions installed in the source tree.

[klihub]

Now I got it working locally, too. Was just a stupid user error.

[klihub]

LGTM. Thank you !

[marquiz]

@klihub updated. Check it. The build from source case was broken in the previous version. I hope I got it right...

[klihub]

@klihub updated. Check it. The build from source case was broken in the previous version. I hope I got it right...

@marquiz It already looked good to me before you noticed that that on those architectures/path it was broken and fixed it. 🙈 😜

[marquiz]

Thanks @klihub for the review.

One possible change I had in mind is:

-INSTALL_DIR="$PWD/build/tools"
+PROTOC_DIR="$PWD/build/protoc"

That would make it completely wipe/clean protoc and deps e.g. in case of version bumps. Thoughts?

@mikebrow @chrishenzie @thaJeztah

[klihub]

Thanks @klihub for the review.

One possible change I had in mind is:

-INSTALL_DIR="$PWD/build/tools"
+PROTOC_DIR="$PWD/build/protoc"

That would make it completely wipe/clean protoc and deps e.g. in case of version bumps. Thoughts?

@mikebrow @chrishenzie @thaJeztah

@marquiz Sorry, you lost me there... I think. So instead of installing protoc to a common build/tools[/bin] we'd put it in a dedicated build/protoc ? But isn't #233 already doing that, IOW wiping and reinstalling in case of version bump within the same git worktree, but without installing protoc to a (more) dedicated directory ?

[marquiz]

I think. So instead of installing protoc to a common build/tools[/bin] we'd put it in a dedicated build/protoc ? But isn't #233 already doing that, IOW wiping and reinstalling in case of version bump within the same git worktree, but without installing protoc to a (more) dedicated directory ?

It's like build/tools/{bin,lib,include} (and possibly even build/tools/src). #233 does not wipe anything, just copies over :/ If we install into protoc-specific path we can just rm -rf it without breaking any other tooling (that we might add in the generic tools dir in the future).