feat: use stricter regex to filter network labels on the container. #4319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tushar5526
force-pushed
the
use-stricter-regex-filter-match-network-labels
branch
2 times, most recently
from
2c2e68b to
e03655b
Compare
This allows us to skip double checking the network names on the container with an additional helper function. Signed-off-by: Tushar Gupta <[email protected]>
tushar5526
force-pushed
the
use-stricter-regex-filter-match-network-labels
branch
from
e03655b to
e5ab123
Compare
|
It does not look like the failing test is related to the changes made here. Are they flaky? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to skip double-checking the network names on the container with an additional helper function.
Related to #4282
Network related labels on a Container are stored as follows:
The new regex in this PR, exactly matches the network name, taking in account the
\and"