Skip to content

Add cleanup IO process after nerdctl stop #4316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add cleanup IO process after nerdctl stop #4316

wants to merge 1 commit into from

Conversation

liuchangyan
Copy link

Fix #4315
In the ctr and CRI call paths of containerd, the remaining FIFO files (e.g., /run/containerd/fifo) are primarily cleaned up through the Delete interface of the task. However, in the nerdctl stop path, this interface is not invoked, so an explicit call to io.Close is required to clean them up.

@liuchangyan liuchangyan mentioned this pull request Jun 13, 2025
Open
@fahedouch
Copy link
Member

can we have a test please ?

@liuchangyan
Copy link
Author

can we have a test please ?

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nerdctl stop could not cleanup fifo files(/run/containerd/fifo)
2 participants
@liuchangyan @fahedouch