add hostname to the labels of the metrics; pull out calls to metrics …

[mike-kingsbury]

Adds hostnames to metrics; pull out metrics functionality to metrics.py file, suggested by Bruno.

Signed-off-by: Mike Kingsbury [email protected]

Maintainers will complete the following section

• Commit messages are descriptive enough
• Code coverage from testing does not decrease and new code is covered
• New code has type annotations
• n/a OpenAPI schema is updated (if applicable)
• n/a DB schema change has corresponding DB migration (if applicable)
• n/a README updated (if worker configuration changed, or if applicable)

[chmeliik]

Seems reasonable 👍

Are there any tests for these metrics that could be updated? If we have none, that's probably OK

[brunoapimentel]

Seems reasonable +1

Are there any tests for these metrics that could be updated? If we have none, that's probably OK

I don't think there are any :(

WIth this change, it should be easy enough to add unit tests for metrics.py. I also agree it's probably OK to have this merged without the tests, they can be added as an improvement later.

[brunoapimentel]

Overall, LGTM. Only fix needed is adding type annotations, as mentioned.

[MartinBasti]

What's the status of this PR? Is it pending review or pending changes?

[mike-kingsbury]

Should be now pending review, changes were made to the annotations

[chmeliik]

Are the requirements*.txt changes intentional? A lot of dependencies got downgraded, as well as the python version used to generate the files

[fepas]

Shouldn't we keep running pip-compile using python 3.10 since it's the newest version? (if there is any difference between using 3.9 and 3.10). Apart from that, LGTM

[mike-kingsbury]

Let me revisit this, I may have done the wrong thing during a rebase...

…

On Tue, Nov 22, 2022 at 4:25 AM Adam Cmiel ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In requirements-web.txt <#707 (comment)> : > -mako==1.2.2 \ - --hash=sha256:3724869b363ba630a272a5f89f68c070352137b8fd1757650017b7e06fda163f \ - --hash=sha256:8efcb8004681b5f71d09c983ad5a9e6f5c40601a6ec469148753292abc0da534 +mako==1.2.1 \ Are the requirements*.txt changes intentional? A lot of dependencies got downgraded, as well as the python version used to generate the files — Reply to this email directly, view it on GitHub <#707 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATFBKRMKLNZYZDUQUUPJQUTWJSGRDANCNFSM6AAAAAAQMXQFVE> . You are receiving this because you authored the thread.Message ID: ***@***.***>