Only compile history_custom example if history feature is enabled #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francisdb
changed the title
francisdb
force-pushed
the
fix/only_run_history_custom_example_if_feature_enabled
branch
from
3a4eecd to
1bd0c90
Compare
|
@djc are you actively taking over this project? |
djc
approved these changes
Sep 3, 2025
francisdb
deleted the
fix/only_run_history_custom_example_if_feature_enabled
branch
|
I wouldn't say actively, but I will be available to do code review. |
Thanks, I was motivated to come up with a pr by seeing repo activity :-) |
|
Yup -- I had forgotten to enable notifications for this repo, but I've done so now so future response should be faster. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #334