Skip to content

docs: update puppeteer launch options in README for clarity; add CI/CD hint #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

knbknb
Copy link

@knbknb knbknb commented Mar 8, 2025

Title: Enhance Documentation:

  • only 2 README files are affected
    • update 1 external Link (to Puppeteer Source Code Repo)
    • Provided 1 example for setting puppeteerLaunchOptions in config.ts
    • Clarified the use of puppeteerLaunchOptions in CI/CD environments to avoid permission issues when Chrome runs as root. This is more a hint, perhaps it helps someone

// In CI/CD pipeline, if Chrome runs as `root` user, set options to avoid permission issues.
export default defineUserConfig({
// ...
puppeteerLaunchOptions: { headless: true, args: ['--disable-gpu', '--no-sandbox', '--disable-setuid-sandbox' ]},
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comments to each parameter please.

@condorheroblog condorheroblog self-assigned this Mar 8, 2025
@condorheroblog condorheroblog added the documentation Improvements or additions to documentation label Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants