unvendor zlib #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

isuruf wants to merge 13 commits into conda-forge:main from isuruf:unvendor_zlib

Member

isuruf commented Sep 19, 2024

Checklist

Used a personal fork of the feedstock to propose changes
Bumped the build number (if the version is unchanged)
Reset the build number to 0 (if the version changed)
Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
Ensured the license file is being packaged.


          unvendor zlib

f2f3dca

isuruf requested review from jakirkham, matthiasdiener, msarahan, ocefpaf, pelson and xhochy as code owners

September 19, 2024 19:04

isuruf added the automerge label

conda-forge-webservices bot commented Sep 19, 2024

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

This recipe is using a compiler, which now requires adding a build dependence on {{ stdlib("c") }} as well. Note that this rule applies to each output of the recipe using a compiler. For further details, please see META: {{ stdlib("c") }} migration conda-forge.github.io#2102.


          stdlib

ebab954

conda-forge-webservices bot commented Sep 19, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.


          cross compile

538c65d

github-actions bot removed the automerge label

github-actions bot commented Sep 19, 2024

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

Member Author

isuruf commented Sep 19, 2024

@conda-forge-admin, rerender

conda-forge-webservices[bot] and others added 5 commits

September 19, 2024 19:08


          MNT: Re-rendered with conda-build 24.7.1, conda-smithy 3.40.1, and co…

cc68258

…nda-forge-pinning 2024.09.19.16.13.28


          update patch

be8eaf3


          need libpng-devel

dd1a2bd


          zlib dep on windows

74d61ce


          Fix yum and cdt

54fb17e

isuruf added the automerge label


          expat-devel

eb8ebfb

github-actions bot removed the automerge label

github-actions bot commented Sep 19, 2024

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!


          libxrender

b40a40d

isuruf added the automerge label

github-actions bot commented Sep 19, 2024

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

linter: passed
azure: failed

Thus the PR was not passing and not merged.


          expat in yum

b62cc7a

github-actions bot removed the automerge label

github-actions bot commented Sep 19, 2024

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!


          libuuid

8afddc5

isuruf added the automerge label


          Update meta.yaml

07f5ce4

github-actions bot removed the automerge label

github-actions bot commented Sep 19, 2024

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

hmaarrfk reviewed

View reviewed changes

recipe/meta.yaml

    
                  - {{ cdt('libXft-devel') }}          # [linux and tk_variant == 'xft']

                  - {{ cdt('libpng-devel') }}          # [linux and tk_variant == 'xft']

                  - {{ cdt('libuuid-devel') }}         # [linux and tk_variant == 'xft']

                  - {{ cdt('expat-devel') }}           # [linux and tk_variant == 'xft']

hmaarrfk Sep 29, 2024

are we ready in 2024 to remove these CDTs as well?

hmaarrfk Sep 29, 2024

xref: #63

hmaarrfk reviewed

View reviewed changes

recipe/meta.yaml

    
              test:

                requires:

                  # needs to run emulated tests

                  - bzip2  # [build_platform != target_platform]

hmaarrfk Sep 29, 2024

This is very curious.

If this is not needed by the native builds, it must be finding libbzip2 from some other environment and adopting it right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hmaarrfk hmaarrfk left review comments

jakirkham Awaiting requested review from jakirkham jakirkham is a code owner

matthiasdiener Awaiting requested review from matthiasdiener matthiasdiener is a code owner

msarahan Awaiting requested review from msarahan msarahan is a code owner

ocefpaf Awaiting requested review from ocefpaf ocefpaf is a code owner

pelson Awaiting requested review from pelson pelson is a code owner

xhochy Awaiting requested review from xhochy xhochy is a code owner

Labels

None yet