Skip to content

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Mar 24, 2025

#79 contained an error, as the vtk941 migration file was named .ci_support/migrations/vtk941.yml instead of .ci_support/migrations/vtk941.yaml (the difference is in the yml extension that must be yaml.

I also added a check on find_package(PCL) working correctly to the CI that it would have catched the issue if present.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

It seems that find_package(VTK) fails if one just depends on vtk with vtk 9.4.1, I guess we need to bring this back to the vtk feedstock.

@traversaro
Copy link
Contributor Author

xref: RoboStack/robostack.github.io#65

@traversaro traversaro closed this Mar 27, 2025
@traversaro traversaro reopened this Mar 27, 2025
@traversaro
Copy link
Contributor Author

It seems that find_package(VTK) fails if one just depends on vtk with vtk 9.4.1, I guess we need to bring this back to the vtk feedstock.

Ok, I think to avoid being blocked we can add the required run dependencies to ensure that find_package(PCL) here, see RoboStack/robostack.github.io#65 (comment) .

@traversaro traversaro changed the title Fix vtk941.yml migration extension and add find_package(PCL) check Fix vtk941.yml migration extension and add run dependencies to ensure find_package(PCL) is successful Mar 27, 2025
@traversaro
Copy link
Contributor Author

ppc64le is failing I guess due to the failure in conda-forge/vtk-feedstock#373 (comment) .

@traversaro
Copy link
Contributor Author

There are still failures like:

-- Could NOT find LZMA (missing: LZMA_LIBRARY LZMA_INCLUDE_DIR) 
-- Could not find the VTK package due to a missing dependency: LZMA

let's just wait for conda-forge/vtk-feedstock#375 .

@oleg-alexandrov
Copy link

The pcl conda package is incompatible with icu >=75.1, which is needed to install libgdal=3.11.0 on Mac Arm.

I am not sure if that is related to the vtk error here, but in either case likely versions of pcl need to be produced with newer dependencies. Thank you.

@traversaro
Copy link
Contributor Author

The pcl conda package is incompatible with icu >=75.1, which is needed to install libgdal=3.11.0 on Mac Arm.

I am not sure if that is related to the vtk error here, but in either case likely versions of pcl need to be produced with newer dependencies. Thank you.

Yes, that is the reason why I opened conda-forge/conda-forge-pinning-feedstock#7412 . vtk 9.4.1 builds have several problems, so it is easier to just concentrate the work on vtk 9.4.2 .

@traversaro
Copy link
Contributor Author

Superseded by #82 .

@traversaro traversaro closed this May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants