-
-
Notifications
You must be signed in to change notification settings - Fork 15
Fix vtk941.yml migration extension and add run dependencies to ensure find_package(PCL) is successful #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix vtk941.yml migration extension and add run dependencies to ensure find_package(PCL) is successful #81
Conversation
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
…nda-forge-pinning 2025.03.23.21.47.32
It seems that |
Ok, I think to avoid being blocked we can add the required run dependencies to ensure that |
ppc64le is failing I guess due to the failure in conda-forge/vtk-feedstock#373 (comment) . |
There are still failures like:
let's just wait for conda-forge/vtk-feedstock#375 . |
The pcl conda package is incompatible with icu >=75.1, which is needed to install libgdal=3.11.0 on Mac Arm. I am not sure if that is related to the vtk error here, but in either case likely versions of pcl need to be produced with newer dependencies. Thank you. |
Yes, that is the reason why I opened conda-forge/conda-forge-pinning-feedstock#7412 . vtk 9.4.1 builds have several problems, so it is easier to just concentrate the work on vtk 9.4.2 . |
Superseded by #82 . |
#79 contained an error, as the
vtk941
migration file was named.ci_support/migrations/vtk941.yml
instead of.ci_support/migrations/vtk941.yaml
(the difference is in theyml
extension that must beyaml
.I also added a check on
find_package(PCL)
working correctly to the CI that it would have catched the issue if present.Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)