See issue #10 - retry more cases. Set retry RandomizationFactor to 0.3.

retry_backoff.go

@@ -33,11 +33,10 @@ func NewExponentialBackOffFactory(timeout time.Duration) BackOffFactory {
 func (f *exponentialBackOffFactory) NewBackOff() BackOff {
 	b := backoff.NewExponentialBackOff()
 	b.InitialInterval = 1 * time.Second
-	b.RandomizationFactor = 0
+	b.RandomizationFactor = 0.3
 	b.Multiplier = 2
 	b.MaxInterval = 16 * time.Second
 	b.MaxElapsedTime = f.timeout
-	b.Clock = backoff.SystemClock
 
 	return b
 }

retryer.go

@@ -9,40 +9,68 @@ import (
 
 //go:generate counterfeiter . Retryer
 
+// Retryer defines an interface for determining if an error is retryable
 type Retryer interface {
 	IsRetryable(err error) bool
 }
 
+// DefaultRetryer implements the Retryer interface with common retry logic
 type DefaultRetryer struct{}
 
+// IsRetryable determines if the given error should trigger a retry
 func (r *DefaultRetryer) IsRetryable(err error) bool {
-	if neterr, ok := err.(net.Error); ok {
-		if neterr.Temporary() {
+	if err == nil {
+		return false
+	}
+
+	// Check for net.Error interface implementation and Temporary() or Timeout() status
+	if netErr, ok := err.(net.Error); ok {
+		if netErr.Temporary() || netErr.Timeout() {
 			return true
 		}
 	}
 
-	s := err.Error()
-	for _, retryableError := range defaultRetryableErrors {
-		if strings.HasSuffix(
-			strings.ToLower(s),
-			strings.ToLower(retryableError.Error())) {
+	// Check if the error is in our predefined list of retryable errors
+	var sysErr syscall.Errno
+	if errors.As(err, &sysErr) {
+		for _, code := range retryableSyscallErrors {
+			if sysErr == code {
+				return true
+			}
+		}
+	}
+
+	// Fall back to string matching for other error types
+	errMsg := strings.ToLower(err.Error())
+	for _, msg := range retryableErrorMessages {
+		if strings.Contains(errMsg, msg) {
 			return true
 		}
 	}
 
 	return false
 }
 
-var defaultRetryableErrors = []error{
-	syscall.ECONNREFUSED, // "connection refused"
-	syscall.ECONNRESET,   // "connection reset by peer"
-	syscall.ETIMEDOUT,    // "operation timed out"
-	errors.New("i/o timeout"),
-	errors.New("no such host"),
-	errors.New("handshake failure"),
-	errors.New("handshake timeout"),
-	errors.New("timeout awaiting response headers"),
-	errors.New("unexpected EOF"),
-	errors.New("unexpected EOF reading trailer"),
+// Syscall error codes that should trigger a retry
+var retryableSyscallErrors = []syscall.Errno{
+	syscall.ECONNREFUSED, // Connection refused - The server is not listening on the specified port or is unreachable
+	syscall.ECONNRESET,   // Connection reset by peer - The server abruptly closed the connection without proper termination
+	syscall.ETIMEDOUT,    // Operation timed out - The connection or request did not complete within the allotted time
+	syscall.EPIPE,        // Broken pipe - Attempt to write to a socket that has been closed by the peer
+}
+
+// Error message substrings that should trigger a retry
+var retryableErrorMessages = []string{
+	"i/o timeout",
+	"no such host",
+	"handshake failure",
+	"handshake timeout",
+	"timeout awaiting response headers",
+	"net/http: timeout awaiting response headers", // Specific to http package timeouts
+	"unexpected eof",
+	"connection reset by peer",
+	"read: connection reset by peer",
+	"read on closed response body",
+	"broken pipe",
+	"use of closed network connection",
 }