Added threads subsetting in emcc compiler model #18520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
memsharded
reviewed
Jun 24, 2025
memsharded
approved these changes
Jun 25, 2025
franramirez688
approved these changes
Jun 25, 2025
memsharded
added a commit
to memsharded/conan
that referenced
this pull request
Jul 22, 2025
* Added threads subsetting on emcc compiler model * Fixed test * Return list instead * Update test/integration/toolchains/meson/test_mesontoolchain.py * Added integration tests to every toolchain * WIP fix windows tests * Fix windows autotools tests --------- Co-authored-by: James <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Added
threadssubsetting inemcccompiler model.Docs: conan-io/docs#4115
Close #10088
The
emcccompiler generates binaries that may be incompatible depending on whether threads are used. For more details, refer to the "Note" section in the Emscripten documentation: https://emscripten.org/docs/porting/pthreads.html#compiling-with-pthreads-enabled.According to https://emscripten.org/docs/api_reference/wasm_workers.html:
These two APIs are incompatible with each other.
This incompatibility necessitates the modeling of threading usage within the compiler's binary model. This allows us to distinguish between binaries compiled with threading and those compiled without it. Our goal is to integrate this capability built in, as we strive to provide first-class support for the Emscripten ecosystem.
developbranch, documenting this one.