fix: skip automated PR when no doc content changes#10
Merged
marcusburghardt merged 7 commits intocomplytime:mainfrom Apr 13, 2026
Merged
fix: skip automated PR when no doc content changes#10marcusburghardt merged 7 commits intocomplytime:mainfrom
marcusburghardt merged 7 commits intocomplytime:mainfrom
Conversation
Signed-off-by: sonupreetam <spreetam@redhat.com>
Adds spec.md and tasks.md for the 014-skip-lockfile-only-pr feature using the .specify/templates scaffolding format, documenting the two user stories, acceptance scenarios, requirements, and completed tasks. Made-with: Cursor
Initialises OpenSpec (v1.2.0) with Cursor tooling and creates the full spec-driven artifact set for the 014-skip-lockfile-only-pr feature: proposal → specs (pr-noise-reduction, content-change-detection) → design → tasks. Removes the earlier manually-scaffolded specs/014-*/ files in favour of the canonical openspec/changes/ location. Signed-off-by: sonupreetam <spreetam@redhat.com>
sonupreetam
force-pushed
the
014-skip-lockfile-only-pr
branch
from
ce213b2 to
5367abf
Compare
- Gitignore .cursor/commands/ and .cursor/skills/ — these are installed by `openspec init --tools cursor` and are tool-managed infrastructure, analogous to .specify/scripts/ and .specify/templates/. Run `openspec init --tools cursor` to restore them locally. - Add specs/014-skip-lockfile-only-pr/spec.md and tasks.md in SpecKit format matching specs/006-go-sync-tool/ convention so the permanent feature spec lives alongside other project specs. Made-with: Cursor
Signed-off-by: sonupreetam <spreetam@redhat.com>
sonupreetam
force-pushed
the
014-skip-lockfile-only-pr
branch
2 times, most recently
from
c8190c4 to
ae89f9c
Compare
…ile-only-pr/ The org standard (org-infra PR #185) aligns on SpecKit (specs/NNN-name/) for canonical spec artifacts. openspec/changes/ is tool-managed working state, analogous to .specify/scripts/ — useful locally but not for long-lived project documentation. Gitignore openspec/changes/ and keep only specs/014-skip-lockfile-only-pr/ as the single canonical spec. openspec/config.yaml remains tracked as the project-level tool config. Signed-off-by: sonupreetam <spreetam@redhat.com>
sonupreetam
force-pushed
the
014-skip-lockfile-only-pr
branch
from
ae89f9c to
8de5d03
Compare
sonupreetam
added a commit
to sonupreetam/website
that referenced
this pull request
Apr 10, 2026
- Pass changed_repos via env var instead of direct ${{ }} interpolation
in shell script (security hardening, LOW)
- Remove no-op content/ from add-paths — gitignored build artifacts are
never staged by peter-evans/create-pull-request (MEDIUM)
- Mark IMP-005 as superseded in spec: reviewer visibility into changed
doc files is provided by the writeFileManifest output in the PR body,
not by committing gitignored build artifacts
Signed-off-by: sonupreetam <spreetam@redhat.com>
Made-with: Cursor
sonupreetam
added a commit
that referenced
this pull request
Apr 10, 2026
- Pass changed_repos via env var instead of direct ${{ }} interpolation
in shell script (security hardening, LOW)
- Remove no-op content/ from add-paths — gitignored build artifacts are
never staged by peter-evans/create-pull-request (MEDIUM)
- Mark IMP-005 as superseded in spec: reviewer visibility into changed
doc files is provided by the writeFileManifest output in the PR body,
not by committing gitignored build artifacts
Signed-off-by: sonupreetam <spreetam@redhat.com>
Signed-off-by: sonupreetam <spreetam@redhat.com>
sonupreetam
added a commit
that referenced
this pull request
Apr 10, 2026
- Pass changed_repos via env :var instead of direct ${{ }} interpolation
in shell script (security hardening, LOW)
- Remove no-op content/ from add-paths — gitignored build artifacts are
never staged by peter-evans/create-pull-request (MEDIUM)
- Mark IMP-005 as superseded in spec: reviewer visibility into changed
doc files is provided by the writeFileManifest output in the PR body,
not by committing gitignored build artifacts
Signed-off-by: sonupreetam <spreetam@redhat.com>
Signed-off-by: sonupreetam <spreetam@redhat.com>
sonupreetam
force-pushed
the
014-skip-lockfile-only-pr
branch
from
ca5adcb to
b54dfcc
Compare
- Pass changed_repos via env :var instead of direct ${{ }} interpolation
in shell script (security hardening, LOW)
- Remove no-op content/ from add-paths — gitignored build artifacts are
never staged by peter-evans/create-pull-request (MEDIUM)
- Mark IMP-005 as superseded in spec: reviewer visibility into changed
doc files is provided by the writeFileManifest output in the PR body,
not by committing gitignored build artifacts
Signed-off-by: sonupreetam <spreetam@redhat.com>
Signed-off-by: sonupreetam <spreetam@redhat.com>
Made-with: Cursor
sonupreetam
force-pushed
the
014-skip-lockfile-only-pr
branch
from
b54dfcc to
27638ce
Compare
sonupreetam
added a commit
that referenced
this pull request
Apr 10, 2026
- Pass changed_repos via env :var instead of direct ${{ }} interpolation
in shell script (security hardening, LOW)
- Remove no-op content/ from add-paths — gitignored build artifacts are
never staged by peter-evans/create-pull-request (MEDIUM)
- Mark IMP-005 as superseded in spec: reviewer visibility into changed
doc files is provided by the writeFileManifest output in the PR body,
not by committing gitignored build artifacts
Signed-off-by: sonupreetam <spreetam@redhat.com>
Contributor
Author
|
@marcusburghardt Thank you for you feedbacks. I have removed the content/, it no-op you are right. And took care of the other through pass the value via an environment variable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses review feedback from @marcusburghardt on PR #8: the weekly content-sync workflow was opening automated PRs even when no documentation files changed — only the lockfile SHA differed. This made the content approval gate noisy and easy to rubber-stamp.
--update-lock(writes new SHAs to.content-lock.json) then--write(syncs doc content with the new lock, captureshas_changes)if: steps.check.outputs.has_changes == 'true'— PR is skipped when all docs are unchangedsyncResult.hasChanges()to include file-level doc changes (changedRepoFiles) in addition to repo-level project-page changes — previously a repo whose README was unchanged but whose doc sub-pages had new content would emithas_changes=falseOpenSpec
openspec/changes/skip-lockfile-only-pr/— full spec-driven artifact set:proposal.md— why and what changesspecs/pr-noise-reduction/spec.md— workflow gate requirementsspecs/content-change-detection/spec.md—hasChanges()contractdesign.md— key decisions and trade-offstasks.md— 6/6 completeAlso initialises OpenSpec v1.2.0 with Cursor tooling (
.cursor/commands/,.cursor/skills/).Files changed
.github/workflows/sync-content-check.ymlif:guard on PR stepcmd/sync-content/sync.gohasChanges()includeschangedRepoFilescmd/sync-content/sync_test.goTestHasChangestableTest plan
go test -race ./cmd/sync-content/... -run TestHasChanges— all 7 subtests passgo test -race ./cmd/sync-content/...— full suite passesMade with Cursor