refactor: deduplicate optional variable checks - #797
Open
tomatotomata wants to merge 1 commit into
Open
Conversation
Member
|
Hi @tomatotomata , thanks for the contribution. What are your plans to continue on this PR? After rebasing it, the failed CI will likely pass. |
Author
|
I rebased the one-file refactor locally onto current upstream The focused checks on the rebased tree pass:
The implementation is unchanged apart from the rebased parent, so the failed CI should be worth rerunning against this history. Let me know what you think about the rebased result. |
marcusburghardt
force-pushed
the
codex/group-satisfied-refactor
branch
from
September 11, 2026 10:52
dd7815c to
1241f66
Compare
marcusburghardt
marked this pull request as ready for review
September 11, 2026 10:52
marcusburghardt
enabled auto-merge
September 11, 2026 11:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extract the duplicated pipe-splitting lookup used for optional target variable groups in
CheckVariablesinto a smallgroupSatisfiedhelper. The summary and verbose paths now share the same implementation, preserving the existing behavior while reducing maintenance surface.Closes #779
Validation
go test -count=1 ./internal/doctorgo vet ./internal/doctorgofmt -w internal/doctor/doctor.gogit diff --checkThe repository's full
go test -racecommand could not run locally because this Windows environment has no C compiler for cgo. The change is a pure refactor and the targeted package tests pass.I used AI assistance for this small refactor and reviewed the repository's AI tooling and contribution guidance.