Syncup with wlav/cppyy #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/test_regression.py
Outdated
Comment on lines
1355
to
1374
| def test45_typedef_resolution(self): | ||
| """Typedefs starting with 'c'""" | ||
|
|
||
| import cppyy | ||
|
|
||
| cppyy.cppdef("""\ | ||
| typedef const int my_custom_type_t; | ||
| typedef const int cmy_custom_type_t; | ||
| """) | ||
|
|
||
| assert cppyy.gbl.CppyyLegacy.TClassEdit.ResolveTypedef("my_custom_type_t") == "const int" | ||
| assert cppyy.gbl.CppyyLegacy.TClassEdit.ResolveTypedef("cmy_custom_type_t") == "const int" |
Collaborator
There was a problem hiding this comment.
This test does not make sense with our fork.
There was a problem hiding this comment.
We need to rework it and fix it upstream, too...
test/test_fragile.py
Outdated
| import cppyy | ||
|
|
||
| cppyy.cppdef("""\ | ||
| #if __has_include(<span>) |
Collaborator
There was a problem hiding this comment.
Suggested change
| #if __has_include(<span>) | |
| #if __cplusplus >= 202002 |
There was a problem hiding this comment.
Why do we need this instead of the has_include?
Collaborator
There was a problem hiding this comment.
Look at https://godbolt.org/z/6E8v4vooo with and without the -std=c++20.
There was a problem hiding this comment.
Good catch. Can you make sure this is updated upstream too?
Collaborator
|
Hi @aaronj0, I guess you forgot to sync the |
…ena volatility, e.g. by the default compiler) from wlav@777f55e
This part of the test was performed incorrectly, the for loop uses j, and the value of i fixes the comparison to `short` only and ignores the other types; This caused the test to pass by chance. This has been rewritten with an outer loop that goes over the different type names (name) and j that iterates over the array indices. The values of `alpha` were also incorrect and did not reflect the multiplier used in the test dictionary. Another point to note is in the case of signed char, the pointer `m_schar_array2` is implicitly converted to `std::basic_string` while the fixed size array `m_schar_array` is not. Using the getter `get_schar_array2` however works here and we only compare using the instance retrieved this way and skip comparing `c.m_schar_array2` for this reason.
… us the same template proxy to f()
While this check consistently passes locally, sporadically failures are visibble on certain runners and is sensitive to the execution environment, especially CI machines under high load.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings our cppyy frontend up to date with wlav/cppyy:
Introduces all new tests (up to 540)
Adds new functions to the frontend (macro, as_memoryview)
Updates dictionaries for the same
Requires updating test tags based on CI results