treat int8_t and uint8_t as special cases
#167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgvassilev
reviewed
Aug 7, 2025
clingwrapper/src/clingwrapper.cxx
Outdated
| } | ||
|
|
||
| Cppyy::TCppType_t Cppyy::GetRealType(TCppType_t type) { | ||
| TCppType_t check_int_typedefs = type; |
Collaborator
There was a problem hiding this comment.
Can we move the duplicated code in a helper function?
Vipul-Cariappa
force-pushed
the
dev/int8_t
branch
from
724353f to
756a377
Compare
resolving them yields `char`, but we want to treat them as `int`s therefore we treat them as special cases
Vipul-Cariappa
force-pushed
the
dev/int8_t
branch
from
756a377 to
81b85ab
Compare
vgvassilev
reviewed
Aug 8, 2025
| return type; | ||
| } | ||
|
|
||
| Cppyy::TCppType_t int_like_type(Cppyy::TCppType_t type) { |
Collaborator
There was a problem hiding this comment.
Doesn’t that try to get the canonical type of a given type?
Collaborator
Author
There was a problem hiding this comment.
If the type is int8_t or uint8_t, pointer or reference combinations of it. We do not resolve it char/unsigned char. Because we want to treat them like ints, not chars. Retrieving the canonical type will return the char types. So we need to avoid it here.
vgvassilev
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolving them yields
char, but we want to treat them asints therefore we treat them as special casesfixes 1 test