Skip to content

Conversation

@Vipul-Cariappa
Copy link
Collaborator

@Vipul-Cariappa Vipul-Cariappa commented Oct 16, 2024

fixes 5 tests


Explanation of the change:
line 178 needs to be executed to trim extra white space. As there is a string comparison later on.

@Vipul-Cariappa
Copy link
Collaborator Author

ping @aaronj0, @vgvassilev

Copy link

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! LGTM!

@vgvassilev vgvassilev merged commit 66d7196 into compiler-research:master Oct 16, 2024
15 checks passed
@Vipul-Cariappa Vipul-Cariappa deleted the bug-fix branch October 16, 2024 14:04
Vipul-Cariappa added a commit to Vipul-Cariappa/cppyy-compiler-research that referenced this pull request Oct 17, 2024
Vipul-Cariappa added a commit to Vipul-Cariappa/cppyy-compiler-research that referenced this pull request Oct 17, 2024
aaronj0 pushed a commit to compiler-research/cppyy that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants