Quality of life changes - #1
Merged
Merged
Conversation
…each chain's handler
Deiadara
marked this pull request as draft
October 16, 2025 17:08
themicp
requested changes
Oct 29, 2025
themicp
approved these changes
Oct 29, 2025
themicp
marked this pull request as ready for review
October 29, 2025 15:22
themicp
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QueueTraitto enable Queue mocking for testsclippy.tomlIncluderWorkerto provide aTaskHandlerTraitfor each chain to implement, instead of having the same logic for every chain based onBroadcastResult. This was needed due to Solana's GatewayTx task needing multiple transactions to complete, and will probably be useful in the future.Includerto move the chain-specific logic to each implementation and have the core just take the results and post to the GMP API.Note that these changes are breaking and each Relayer will need to implement them.