refactor(Init): remove the variable values_to_add and the _update_config_file function for readability #1537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v4-9-0-test #1537 +/- ##
==============================================
Coverage ? 98.31%
==============================================
Files ? 58
Lines ? 2670
Branches ? 0
==============================================
Hits ? 2625
Misses ? 45
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bearomorphism
force-pushed
the
r-init-values-to-add
branch
from
7da709d to
dfc17bd
Compare
bearomorphism
changed the title
Lee-W
approved these changes
Aug 17, 2025
Lee-W
added
pr-status: ready-to-merge
…ig function for readability
bearomorphism
force-pushed
the
r-init-values-to-add
branch
from
9311261 to
c5f93cb
Compare
bearomorphism
force-pushed
the
r-init-values-to-add
branch
from
c5f93cb to
65cda83
Compare
|
just fixed conflict, please review |
Lee-W
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist