Skip to content

pakistan holidays #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

pakistan holidays #138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions data/countries/PK.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
holidays:
PK:
names:
en: Pakistan
langs: []
Copy link
Owner

@commenthol commenthol Jan 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add the languages used in this data?
e.g.

  • en
  • ur (Urdu)
    It would be nice if you could also add local languages if available e.g. Urdu

zones:
- Asia/Karachi
dayoff: sunday
days:
02-05:
type: observance
name:
en: Kashmir Solidarity Day
03-23:
type: observance
Copy link
Owner

@commenthol commenthol Jan 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you pls. check if "type" is correct.
See https://github.com/commenthol/date-holidays/blob/master/docs/specification.md#types-of-holidays

observance means that there that some people celebrate the day
public instead means there is some kind of law which declares the day as public holiday

name:
en: Pakistan Day
02-01:
Copy link
Owner

@commenthol commenthol Jan 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it 1st February or 05-01 = 1st May?

type: observance
name:
en: Labour Day
08-14:
type: observance
name:
en: Independence Day of Pakistan
12-25:
type: observance
name:
en: Quaid-e-Azam's Birthday
# states:
Copy link
Owner

@commenthol commenthol Jan 27, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible for you to add also muslim holidays? You can find them here https://github.com/commenthol/date-holidays/blob/master/docs/specification.md#hijra-dates. Maybe some of them could apply to Pakistan.

# BA:
# name: Balochistan
# GB:
# name: Gilgit-Baltistan
# IS:
# name: Islamabad
# JK:
# name: Azad Kashmir
# KP:
# name: Khyber Pakhtunkhwa
# PB:
# name: Punjab
# SD:
# name: Sindh
# TA:
# name: Federally Administered Tribal Areas