Skip to content

zero-initialize fds and buffs before ipc_sendrecv_with_fds #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deanlee wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −4
Open

zero-initialize fds and buffs before ipc_sendrecv_with_fds #659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions msgq/visionipc/visionipc_client.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ bool VisionIpcClient::connect(bool blocking){
assert(r == sizeof(type));

// Get FDs
int fds[VISIONIPC_MAX_FDS];
VisionBuf bufs[VISIONIPC_MAX_FDS];
int fds[VISIONIPC_MAX_FDS] = {};
VisionBuf bufs[VISIONIPC_MAX_FDS] = {};
r = ipc_sendrecv_with_fds(false, socket_fd, &bufs, sizeof(bufs), fds, VISIONIPC_MAX_FDS, &num_buffers);
if (r < 0) {
// only expected error is server shutting down
Expand Down
4 changes: 2 additions & 2 deletions msgq/visionipc/visionipc_server.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,9 @@ void VisionIpcServer::listener(){
continue;
}

int fds[VISIONIPC_MAX_FDS];
int fds[VISIONIPC_MAX_FDS] = {};
int num_fds = buffers[type].size();
VisionBuf bufs[VISIONIPC_MAX_FDS];
VisionBuf bufs[VISIONIPC_MAX_FDS] = {};

for (int i = 0; i < num_fds; i++){
fds[i] = buffers[type][i]->fd;
Expand Down
Loading