visionipc_pyx: safe VisionBuf life time via client owner reference #658
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deanlee
force-pushed
the
add-owner-reference
branch
from
86da40a to
0a4d9d9
Compare
deanlee
force-pushed
the
add-owner-reference
branch
from
0a4d9d9 to
1217442
Compare
mpurnell1
added a commit
to mpurnell1/msgq
that referenced
this pull request
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fxes a lifetime issue where
VisionIpcClientcould be destroyed while Python still heldVisionBufobjects, leading to use-after-free and crashes. eachVisionBufnow stores an _owner reference to its client/server, ensuring the underlying C++ object stays alive until all buffers are released.