VisionIpcServer: avoid vector copy in get_buffer() #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

deanlee wants to merge 1 commit into commaai:master from deanlee:use-reference

Contributor

deanlee commented Dec 2, 2025

get_buffer() was copying the entire buffers vector on every call:

auto b = buffers[type]; // Creates a full copy of vector<VisionBuf*>

This PR switches to a const& to avoid the copy, reducing overhead.


          use reference

549fa4e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet