fix(comark): preserve nested markup when stringifying del - #387
Merged
Conversation
renderMarkdown flattened del children via textContent, so ~~`x`~~ round-tripped as ~~x~~. Recurse like strong/em, emit attributes, and treat del as an inline HTML tag. Specs cover nested code and attributes. Fixes #266
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
comark
@comark/angular
@comark/ansi
@comark/html
@comark/nuxt
@comark/react
@comark/svelte
@comark/vue
commit: |
Contributor
✅ Bundle snapshot updatedCommitted the new snapshot as 092f510, verified by re-running the bundle check against it. GitHub suppresses the events a workflow commit would normally raise, so the Produced by this run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
delchildren inrenderMarkdown(likestrong/em) instead of flattening withtextContent, so nested inlines such as~~\x`~~` round-trip correctlydelattributes after the closing~~delimiterdelas an inline tag in HTML stringify so output stays on one linedeland fordelattributesFixes #266
Test plan
pnpm vitest run test/index.test.tsinpackages/comark(656 passed)~~\x``x`~~`parses and stringifies back to~~*x*~~{.gone}round-trips attributes and nested emphasis