-
Notifications
You must be signed in to change notification settings - Fork 744
feat: Enable Custom WebSocket URLs for Solana Payments #468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
amilz
wants to merge
17
commits into
coinbase:main
Choose a base branch
from
amilz:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add custom RPC subscription
🟡 Heimdall Review Status
|
|
@amilz is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
@CarsonRoscoe please let us know if this looks good or needs more work. Think it's ready for merge |
Contributor
Author
|
@CarsonRoscoe - wondering if you could take a look at this one when you get a chance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces
rpcSubscriptionsUrlto theSvmConfigthat we introduced in #416. Though the existing logic includes public websocket endpoints and sensible/common default rules (replace 'http' with 'ws' to derive a websocket url from RPC endpoint), sometimes operators have websocket endpoints that do not comply with that assumption. In particular, the local test validator operates on different ports so the simple text replace does not work (http://127.0.0.1:8899currently maps tows://127.0.0.1:8899but actually needs port 8900).The primary upgrade here is to
getRpcSubscriptionsto allow custom URLs when passed with some simple helper functions for readability/reusability.I have also shared/reviewed with @notorious-d-e-v (thank you 🙏).
Tests
Updated:
typescript/packages/x402/src/shared/svm/rpc.test.tstypescript/packages/x402/src/schemes/exact/svm/facilitator/settle.test.tsChecklist