-
-
Notifications
You must be signed in to change notification settings - Fork 6
Various fixes against the v25 branch. #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v25
Are you sure you want to change the base?
Conversation
The code was previously passing a pointer to the handle to c code. The pointer could be garbage collected before being used.
… that can be passed as an unsafe.Pointer or as a void* in c.
|
Fixed the handle issue by introducing our own |
|
Note: i've now forked the repository and added more things on the main branch, that you might not want to have upstream. This includes improved garbage collection of wgpu resources, makeing calls to |
|
It would be really nice to hear from the maintainers, if there are plans to either merge these improvements or cherry pick certain things out of it. |
|
@kkoreilly and I will have a chance to discuss this soon and will post an update within a couple of weeks hopefully! |
I can split the PR up into multiple small onces, but as the v25 PR is already one single big PR, i just went with another big one ;)
cgo.HandleDesiredMaximumFrameLatencyinSurfaceConfigurationQueue.WriteBufferandQueue.WriteTextureVertexFormat.Size()Texturefor js.