feat: add LAPSv2 support for haslaps detection#58
Open
ashley4234 wants to merge 1 commit intocoffeegist:mainfrom
Open
feat: add LAPSv2 support for haslaps detection#58ashley4234 wants to merge 1 commit intocoffeegist:mainfrom
ashley4234 wants to merge 1 commit intocoffeegist:mainfrom
Conversation
ashley4234
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@coffeegist
Hello, thank you for the great project.
Summary
msLAPS-PasswordExpirationTime(Windows LAPS / LAPSv2) attribute toCOMMON_PROPERTIESandhaslapsdetection logic.ms-Mcs-AdmPwdExpirationTime) was checked, causinghaslapsto beFalsein modern environments.ReadLAPSPasswordedges are correctly generated in BloodHound, as the ACL processing inadds.pyalready supports LAPSv2 GUIDs.Test plan
haslaps=Truewhen only the LAPSv2 attribute is present on a computer object.python -m pytest tests/ad/models/test_bloodhound_computer.py -v