Fix TrustDirection/TrustType enum crash with newer bloodhound.py#56
Open
chryzsh wants to merge 1 commit intocoffeegist:mainfrom
Open
Fix TrustDirection/TrustType enum crash with newer bloodhound.py#56chryzsh wants to merge 1 commit intocoffeegist:mainfrom
chryzsh wants to merge 1 commit intocoffeegist:mainfrom
Conversation
Newer versions of bloodhound.py's ADDomainTrust.to_output() return string names (e.g. 'Inbound') instead of integer values for TrustDirection and TrustType. The enum conversion now only runs when the value is still an integer, maintaining backward compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer versions of bloodhound.py's ADDomainTrust.to_output() return string names (e.g. 'Inbound') instead of integer values for TrustDirection and TrustType. The enum conversion now only runs when the value is still an integer, maintaining backward compatibility. I've tested on newer datasets that this solves the problem, but I don't have any old datasets that only use integer to test.