support php84 (and fix deprecations) #134
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @champix! Would you mind removing 8.1 from supported versions? I try to keep only 3 supported versions among all projects I'm maintaining |
|
you also need to add 8.4 in CI/CD test suite, and move static analysis to 8.2 from 8.1 |
|
You might need to run static analysis locally and fix those errors first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Log
Added
Fixed
Changed
Removed
Deprecated
Security
Description
PHP 8.4 Support
TBH it worked but it threw some deprecation errors (see below)
Deprecated: Coduo\PHPHumanizer\String\BinarySuffix::__construct(): Implicitly marking parameter $precision as nullable is deprecated, the explicit nullable type must be used instead in #REDACTED#\vendor\coduo\php-humanizer\src\Coduo\PHPHumanizer\String\BinarySuffix.php on line 37