fix(provider-sherpa): prevent memory leaks in reconnection and timers #1206
+22
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Track delayedReconnect setTimeout in this.reconnectTimer so it can be cancelled on cleanup/shutdown (previously fired even after SIGTERM) - Remove infinite recursive initVendor() call in releaseTmp catch block; now logs and continues instead of looping forever - Store releaseTmp interval ID and clear previous one before creating new on each reconnect (each reconnect leaked a new setInterval) - Clear releaseTmpTimer in cleanup() - Fix cleanup() writing to logger AFTER closing logStream (moved log before stream.end()) https://claude.ai/code/session_01MdHmTdMDSZe8BrtSZC8Hgt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://claude.ai/code/session_01MdHmTdMDSZe8BrtSZC8Hgt
Que tipo de Pull Request es?
Descripción
Por favor agrega una descripción de tu aporte para tener más contexto y poder avanzar más rápido. Si es de ayuda puedes usar plataformar como https://www.loom.com/ para grabar un video.