fix(logging): corrects InterceptHandler frame walker off-by-one#587
Open
vivekkeshore wants to merge 1 commit into
Open
fix(logging): corrects InterceptHandler frame walker off-by-one#587vivekkeshore wants to merge 1 commit into
vivekkeshore wants to merge 1 commit into
Conversation
What: walk from `currentframe().f_back` with `depth=1`, not `currentframe()` with `depth=2`. Why: `currentframe()` returns emit's own frame, so the guard against `logging.__file__` was False on the first check — the loop never ran and intercepted records were attributed to stdlib `Logger.callHandlers` instead of the actual originating caller. How: `.f_back` skips emit so the guard matches stdlib frames and the walk advances; `depth=1` compensates for the skipped frame. Added positive and negative regression tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: walk from
currentframe().f_backwithdepth=1, notcurrentframe()withdepth=2.Why:
currentframe()returns emit's own frame, so the guardagainst
logging.__file__was False on the first check — theloop never ran and intercepted records were attributed to stdlib
Logger.callHandlersinstead of the actual originating caller.How:
.f_backskips emit so the guard matches stdlib frames andthe walk advances;
depth=1compensates for the skipped frame.Added positive and negative regression tests.
Fixes #586