Fix init failing when mobs_dir is outside repo root#21
Merged
Conversation
SaveConfig wrote to .codemob/config.json but never ensured the .codemob/ directory existed inside the repo. When the user picks an external mobs directory (enclosing or global), MkdirAll only creates the external path, so the in-repo .codemob/ is never made and the config write fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SaveConfignow ensures.codemob/exists before writingconfig.jsoncodemob initfailing when the user picks an external mobs directory (enclosing or global), sinceMkdirAllonly created the external path but never the in-repo.codemob/Test plan
codemob initand pick option 2 (enclosing dir) - should succeedcodemob initand pick option 3 (global dir) - should succeedcodemob initand pick option 1 (project dir) - should still work as before