Next 정부광 sprint11#78
Closed
aha-hyeong wants to merge 2 commits intocodeit-sprint-fullstack:next-정부광from
Hidden character warning
The head ref may contain hidden characters: "next-\uc815\ubd80\uad11-sprint11"
Closed
Conversation
Collaborator
aha-hyeong
commented
Sep 10, 2025
aha-hyeong
commented
- 로그인, 회원가입 페이지는 header, footer 없음
- 로그인 페이지 / 이메일, 비밀번호 유효성 검사
- 유효성 검사 이상 없는 경우 로그인 버튼 활성화
- form 기본 동작 막기
- components/MainLogo.tsx 페이지 마다 사이즈 변경(home, login)
wseungjin
approved these changes
Sep 10, 2025
Collaborator
wseungjin
left a comment
wseungjin
left a comment
There was a problem hiding this comment.
수고 많으셨습니다~ 제가 질문한 두가지만 답변을 공부를 잘 해도 많은 공부가 될거예요~
| @@ -0,0 +1,23 @@ | |||
| "use client"; | |||
Collaborator
There was a problem hiding this comment.
use client을 어떨떄 써야하고 app router가 pages router랑 뭐가 다른지에 대해서 공부해보시면 좋을꺼같아요~
| import { ReactNode } from "react"; | ||
|
|
||
| export default function ConditionalLayout({ children }: { children: ReactNode }) { | ||
| const pathname = usePathname(); |
Collaborator
There was a problem hiding this comment.
usePathname을 사용하기 위해 클라이언트 컴포넌트를 사용한건가요?
클라이언트 컴포넌트와 서버 컴포넌트의 차이를 한번 공부해보면 좋을꺼 같아요~
| className={styles.submitForm} | ||
| onSubmit={(e) => { | ||
| if (!isFormValid) { | ||
| e.preventDefault(); // 유효하지 않으면 제출X |
| passwordEmpty: "비밀번호를 입력해 주세요.", | ||
| passwordInvalid: `비밀번호를 ${PASSWORD_LENGTH}자 이상 입력해 주세요.`, | ||
| passwordMismatch: "비밀번호가 일치하지 않습니다.", | ||
| emailExists: "사용 중인 이메일입니다.", |
| @@ -0,0 +1,14 @@ | |||
| import { PASSWORD_LENGTH } from "@/utils/validation"; | |||
|
|
|||
| export const errors = { | |||
Collaborator
There was a problem hiding this comment.
authErrors로 네이밍이 좀 더 명확하면 좋을거 같네요
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.