[정남영] 스프린트미션6#63
Merged
wseungjin merged 6 commits intocodeit-sprint-fullstack:react-정남영from Jun 10, 2025
Hidden character warning
The head ref may contain hidden characters: "react-\uc815\ub0a8\uc601"
Merged
Conversation
10 tasks
wseungjin
approved these changes
Jun 10, 2025
| return data.list || []; | ||
| } catch (error) { | ||
| console.error("베스트 상품 가져오기 실패:", error); | ||
| return []; |
Collaborator
There was a problem hiding this comment.
이런 방법도 있긴한데
에러를 만약에 노출할 생각이 있으면 그런것도 고민해서 return값을 줘야 합니다.
| @@ -0,0 +1,38 @@ | |||
| const BASE_URL = "https://panda-market-api.vercel.app/products"; | |||
| import "./productItem.css"; | ||
| import deleteImg from "../../../assets/image/ic_X.png"; | ||
| const ProductItem = ({ name, descript, height, textareaName }) => { | ||
| const [text, setText] = useState(""); |
Collaborator
There was a problem hiding this comment.
text 같은 네이밍은 너무 포괄적인거 같아요
| Mobile: { best: 1, sales: 4 }, | ||
| Tablet: { best: 2, sales: 6 }, | ||
| PC: { best: 4, sales: 10 }, | ||
| Sort: { newest: "recent", like: "favorite" }, |
| <ProductItem | ||
| name={"상품소개"} | ||
| descript={"상품 소개를 입력해주세요"} | ||
| height={"282px"} |
|
|
||
| const [getBestItem, setGetBestItem] = useState([]); | ||
| const [getSalesItem, setGetSalesItem] = useState([]); | ||
| const [salesItems, setSalesItems] = useState([]); |
Collaborator
Author
There was a problem hiding this comment.
급하게하느라 피드백받은 내용을 적용하지못하고 그대로 코드를 가져와서 했습니다 ㅠ 다음스프린트미션때까지 최대한 고쳐서 오도록하겠습니다.
|
|
||
| const Selling = () => { | ||
| const [sort, setSort] = useState("recent"); | ||
| const [startPage, setStartPage] = useState(1); |
Collaborator
There was a problem hiding this comment.
startPage가 정말 필요한게 맞나요?
Collaborator
Author
There was a problem hiding this comment.
이 코드도 기존에있는 코드를 가져와서 제대로 수정못했습니다 다음 미션때까지 최대한 고쳐서 와보도록하겠습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요구사항
기본
프론트엔드
백엔드
codeit-sprint-fullstack/7-sprint-mission-be#3
심화
프론트엔드
주요 변경사항
프론트엔드
백엔드
스크린샷
멘토에게