Express 김세환 sprint6#2
Open
CisThard wants to merge 3 commits intocodeit-sprint-fullstack:express-김세환from
Hidden character warning
The head ref may contain hidden characters: "express-\uae40\uc138\ud658-sprint6"
Open
Conversation
seobew
approved these changes
Dec 11, 2024
seobew
left a comment
There was a problem hiding this comment.
세환님 고생하셨습니다!
mock, seed 같은걸 보니 따로 학습을 열심히 하시는 것 같아서 보기 좋습니다 ㅎㅎ
전반적으로 깔끔하게 작성해주셔서 몇가지 코멘트만 드립니다
수고하셨습니다~
|
|
||
| app.use(cors()); | ||
|
|
||
| const dbUser = process.env.DB_USER; |
There was a problem hiding this comment.
요기부터 아래쪽까지 앞에 빈공간이 있습니다. 요런건 지난번에 말씀드린 prettier를 적용해주시면 깔끔해집니다~
There was a problem hiding this comment.
totalCount 는 필요없는것 같고, list에 안넣어놓고 data에 그대로 넣어놔도 될것 같아요
| const ProductSchema = new mongoose.Schema( | ||
| { | ||
| name: { | ||
| type: String, |
There was a problem hiding this comment.
validation 같은것들도 추가해보면 좋을것 같아요~ min, max 등이요!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요구사항
기본 요구사항
공통
백엔드 구현 요구사항
중고마켓
Product 스키마를 작성해 주세요.
상품 등록 API를 만들어 주세요.
상품 상세 조회 API를 만들어 주세요.
상품 수정 API를 만들어 주세요.
상품 삭제 API를 만들어 주세요.
상품 목록 조회 API를 만들어 주세요.
각 API에 적절한 에러 처리를 해 주세요.
각 API 응답에 적절한 상태 코드를 리턴하도록 해 주세요.
.env 파일에 환경 변수를 설정해 주세요.
CORS를 설정해 주세요.
render.com로 배포해 주세요.
MongoDB를 활용해 주세요.
주요 변경사항
스크린샷
멘토에게