Skip to content

Conversation

@jemeza-codegen
Copy link
Contributor

Motivation

Many attributes have missing docstrings

Content

Adds missing docstrings to attributes of classes decorated with one of apidoc, py_apidoc or ts_apidoc.

Please check the following before marking your PR as ready for review

  • I have added tests for my changes
  • I have updated the documentation or added new documentation as needed

@jemeza-codegen jemeza-codegen requested review from a team and codegen-team as code owners January 31, 2025 00:43
@jemeza-codegen jemeza-codegen requested review from bagel897 and removed request for a team January 31, 2025 00:43
@CLAassistant
Copy link

CLAassistant commented Jan 31, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ jemeza-codegen
❌ codegen-bot


codegen-bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 94.54545% with 3 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...dk/code_generation/doc_utils/generate_docs_json.py 76.92% 3 Missing ⚠️
Additional details and impacted files

@jemeza-codegen jemeza-codegen changed the title Adds docstrings to class attributes missing docstrings CG-10472: Adds docstrings to class attributes missing docstrings Jan 31, 2025
"""Range within the codebase
Attributes:
model_config: Configuration for the model, including JSON encoders.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove

var z
var z = 5
```
_left: The internal representation of the left side of the assignment as an Expression.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't include private attributes

Attributes:
symbol_type: The type of symbol, set to SymbolType.Class.
constructor_keyword: The keyword used to identify the constructor method.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this one

@jemeza-codegen jemeza-codegen deleted the class-attr-docs branch January 31, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants