Skip to content

Fix typo #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jayhack merged 2 commits into from
Feb 5, 2025
Merged

Fix typo #204

jayhack merged 2 commits into from
Feb 5, 2025

Conversation

@simonw
Copy link
Contributor

@simonw simonw commented Jan 30, 2025

Typo in a code example.

@simonw simonw requested review from a team and codegen-team as code owners January 30, 2025 01:44
@simonw simonw requested review from EdwardJXLi and removed request for a team January 30, 2025 01:44
@CLAassistant
Copy link

CLAassistant commented Jan 30, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

caroljung-cg
caroljung-cg approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@caroljung-cg caroljung-cg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing!

caroljung-cg
caroljung-cg approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@caroljung-cg caroljung-cg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@jayhack jayhack merged commit 73daad1 into codegen-sh:develop Feb 5, 2025
1 check passed
@jayhack
Copy link
Contributor

jayhack commented Feb 5, 2025

Thanks @simonw !

jayhack pushed a commit that referenced this pull request Feb 9, 2025
@simonw
Fix typo (#204)
0eb617a 
Typo in a code example.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codegen-team codegen-team Awaiting requested review from codegen-team

2 more reviewers

@EdwardJXLi EdwardJXLi EdwardJXLi approved these changes

@caroljung-cg caroljung-cg caroljung-cg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@simonw @CLAassistant @jayhack @EdwardJXLi @caroljung-cg