CG-10508: Docs explain differences between SourceFile and File types #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 27, 2025 15:21
CG-10508 Get `File.get_symbol(...)` in docs
|
jayhack
requested changes
Jan 28, 2025
Contributor
jayhack
left a comment
jayhack
left a comment
There was a problem hiding this comment.
@jemeza-codegen can we make it more obvious that using raw File is the minority case, and the majority of the time you are iterating over SourceFile?
jayhack
approved these changes
Jan 28, 2025
|
codegen-bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
jayhack
pushed a commit
that referenced
this pull request
Feb 9, 2025
…138) # Motivation SourceFile is currently not mentioned in the Building with Codegen Section # Content Add content explaining the differences between SourceFile and File - [x] I have added tests for my changes (N/A) - [x] I have updated the documentation or added new documentation as needed - [x] I have read and agree to the [Contributor License Agreement](../CLA.md) --------- Co-authored-by: codegen-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
SourceFile is currently not mentioned in the Building with Codegen Section
Content
Add content explaining the differences between SourceFile and File