⚡️ Speed up function find_leaf_nodes
by 23,047%
#29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 23,047% (230.47x) speedup for
find_leaf_nodes
insrc/dsa/nodes.py
⏱️ Runtime :
189 milliseconds
→815 microseconds
(best of475
runs)📝 Explanation and details
Here's a faster version of your function. The original code checks every edge for every node, which can be slow for large graphs (O(N×E)).
This rewrite first collects all node IDs that appear as a source in any edge (O(E)). Then, it performs a single pass over nodes (O(N)) to check which nodes are not in this source set. The new overall complexity is O(N+E).
This is much faster, especially when the number of nodes or edges grows large.
All comments are preserved as before.
✅ Correctness verification report:
🌀 Generated Regression Tests and Runtime
To edit these changes
git checkout codeflash/optimize-find_leaf_nodes-mc8qkoyv
and push.