Fix Java OOM by registering kill as TeardownFunc#292
Merged
Conversation
… in NewShellExecutable
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8cdade5. Configure here.
…ure proper termination of process group
6df155e to
3d028cc
Compare
Member
Author
|
Thanks to @CaseyMcGuire and @mathilch for highlighting the issue! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Changes process lifecycle and SIGKILL teardown for all shell-based tests; behavior is intentional but affects every stage using ShellExecutable on Linux.
Overview
Shell test harnesses now tear down PTY child processes reliably by wiring cleanup that was previously left as a TODO.
NewShellExecutableregistersKill()on stage teardown so the spawned program (and its children) are stopped when a test stage finishes.Kill()is a no-op if nothing was started; otherwise it stops the memory monitor, then sendsSIGKILLto the process group and the leader PID—matching the existing OOM kill path forcreack/ptysession leaders so JVMs and other subprocesses do not keep running and skew memory limits (e.g. Java OOM scenarios).Reviewed by Cursor Bugbot for commit 3d028cc. Bugbot is set up for automated code reviews on this repo. Configure here.