Npm node, with i18n support #4
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i18n use monent relative time concept
retrieve test
…n-concept change to have i18n with relative time from moment
…ring. Will have to live with setting thresholds globally and leaving it to get I18n support with preciseDiff
|
Hello @mtscout6 I tested your fork, and it displays "a few seconds" for seconds. I thought the point of this module was to be precise ?? P.S. why don't you have issues enabled on your fork ? |
|
First, my concern that this library addressed was primarily around accuracy in years. I have not personally dealt with nor needed seconds precision. The i18n support was enticing, hence the reason I ran with that fork. Second, I didn't realize that issues were not enabled till right now. Which I have promptly enabled. I would love pull requests to make it better! |
|
I have finally added this to npm under the name moment-precise-range-plugin so closing this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings in PR #1 as well as changes it to work on npm. In order to get it to work on the browser you could just use browserify, or web-pack. I have published it to npm, although I would be willing to transfer or add you to the ownership; whichever you prefer.