feat: wire up abort_signal for cooperative query cancellation#1
Open
cgycorey wants to merge 1 commit intocodeany-ai:mainfrom
Open
feat: wire up abort_signal for cooperative query cancellation#1cgycorey wants to merge 1 commit intocodeany-ai:mainfrom
cgycorey wants to merge 1 commit intocodeany-ai:mainfrom
Conversation
The abort_signal field existed on QueryEngineConfig, AgentOptions, ToolContext, and with_retry but was never forwarded, read, or checked. This connects the pieces so that setting the signal actually stops the agentic loop, retries, and makes the signal available to tools. - Agent.query() now forwards opts.abort_signal to QueryEngineConfig - QueryEngine.submit_message() checks abort_signal at the top of each agentic turn and returns early if set - _call_api() passes abort_signal to with_retry() - with_retry() checks abort_signal before each retry attempt - _execute_tools() passes abort_signal to ToolContext - Agent.interrupt() sets the event (was a stub: pass)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The abort_signal field existed on QueryEngineConfig, AgentOptions, ToolContext, and with_retry but was never forwarded, read, or checked. This connects the pieces so that setting the signal actually stops the agentic loop, retries, and makes the signal available to tools.